test: increase the platform timeout for AIX #6342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There have been failures on AIX due to the slower default loopback performance. So far I've resisted updating the global timeout but seeing another new failure in a newly added test I now think the right thing is to just extending the platform timeout for AIX. This commit does that.
|
CI run all green |
|
LGTM |
|
LGTM |
mhdawson
added a commit
that referenced
this pull request
Apr 25, 2016
There have been failures on AIX due to the slower default loopback performance. So far I've resisted updating the global timeout but seeing another new failure in a newly added test I now think the right thing is to just extend the platform timeout for AIX. This commit does that. PR-URL: #6342 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Landed as 75e073f |
|
Only needs a backport if #6286 is backported |
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
There have been failures on AIX due to the slower default loopback performance. So far I've resisted updating the global timeout but seeing another new failure in a newly added test I now think the right thing is to just extend the platform timeout for AIX. This commit does that. PR-URL: nodejs#6342 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
There have been failures on AIX due to the slower default loopback performance. So far I've resisted updating the global timeout but seeing another new failure in a newly added test I now think the right thing is to just extend the platform timeout for AIX. This commit does that. PR-URL: #6342 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2016
There have been failures on AIX due to the slower default loopback performance. So far I've resisted updating the global timeout but seeing another new failure in a newly added test I now think the right thing is to just extend the platform timeout for AIX. This commit does that. PR-URL: #6342 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2016
There have been failures on AIX due to the slower default loopback performance. So far I've resisted updating the global timeout but seeing another new failure in a newly added test I now think the right thing is to just extend the platform timeout for AIX. This commit does that. PR-URL: #6342 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
There have been failures on AIX due to the slower
default loopback performance. So far I've resisted
updating the global timeout but seeing another
new failure in a newly added test I now think the
right thing is to just extending the platform
timeout for AIX. This commit does that.
addresses: #6333